ref(browser): Extract getReportDialogEndpoint from API class #4274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this is a public API, we can extract it from the API class as it should only be used by browser.
size-limit report
|
AbhiPrasad
commented
Dec 14, 2021
Comment on lines
-134
to
-138
| if (encodedOptions.length) { | ||
| return `${endpoint}?${encodedOptions.join('&')}`; | ||
| } | ||
|
|
||
| return endpoint; |
There was a problem hiding this comment.
I removed this logic because encodedOptions.push(dsn=${dsn.toString()}); meant that the return endpoint; would never be hit
mitsuhiko
approved these changes
Dec 14, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
Although this is a public API, we can extract it from the API class as it should only be used by browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this is a public API, we can extract it from the API class as it should only be used by browser. Electron and React Native are not using this field.