Skip to content

chore: Introduce internal getHubAndIntegration #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Dec 14, 2021

This is trying to replace the combined used of getCurrentHub and getIntegration with a utility getHubAndIntegration. The desire here is code that's easier to read and understand as well as slightly easier to minify.

This does not yield the intended results like this, so I would not merge it for size reasons. However I think overall combined with other refactorings this would be a sensible change.

@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

size-limit report

Path Base Size (7e0a307) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 21.41 KB 21.49 KB +0.38% 🔺
@sentry/browser - Webpack 23.2 KB 23.26 KB +0.26% 🔺
@sentry/browser - Webpack - gzip = false 81.27 KB 81.42 KB +0.19% 🔺
@sentry/react - Webpack 23.24 KB 23.3 KB +0.26% 🔺
@sentry/nextjs Client - Webpack 47.83 KB 47.92 KB +0.19% 🔺
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.73 KB 29.79 KB +0.23% 🔺

@mitsuhiko
Copy link
Contributor Author

Closing this. If we want to revisit, I would redo this.

@mitsuhiko mitsuhiko closed this Dec 15, 2021
@mitsuhiko mitsuhiko deleted the feature/hub-and-integration branch December 15, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants