ref(utils): Change addInstrumentationHandler to take reg args #4309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing in an object is not necessary as there is always going to be two arguments required. We can just convert this to explicitly passing the options, it saves on bundle size. In addition, we can remove the guards around `type` and `callback` because addInstrumentationHandler is an internally used function, so Typescript and our test suite should handle the function getting called with arguments of the correct type.
AbhiPrasad
commented
Dec 16, 2021
Comment on lines
-86
to
-88
| if (!handler || typeof handler.type !== 'string' || typeof handler.callback !== 'function') { | ||
| return; | ||
| } |
There was a problem hiding this comment.
We can remove this guard because we are the only ones using this addInstrumentationHandler
size-limit report
|
mitsuhiko
approved these changes
Dec 16, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
Change addInstrumentationHandler to take reg args Passing in an object is not necessary as there is always going to be two arguments required. We can just convert this to explicitly passing the options, it saves on bundle size. In addition, we can remove the guards around `type` and `callback` because addInstrumentationHandler is an internally used function, so Typescript and our test suite should handle the function getting called with arguments of the correct type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing in an object is not necessary as there is always going to be two arguments required. We can just convert this to explicitly passing the options, it saves on bundle size. This type change is done in 28b8ef0
In addition, we can remove the guards around
typeandcallbackbecauseaddInstrumentationHandleris an internally used function, so Typescript and our test suite should handle the function getting called with arguments of the correct type.We can (and should) keep refactoring this - but I think this is a good intermediate step. 7659398 updates the browser package with the new
addInstrumentationHandlerimplementation. 3ec7566 does the same for tracing.9d105cd just does some clean up.