ref(utils): Extract SyncPromise static methods into func #4312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
commented
Dec 16, 2021
| @@ -18,7 +18,7 @@ const enum States { | |||
| * Thenable class that behaves like a Promise and follows it's interface | |||
| * but is not async internally | |||
| */ | |||
| class SyncPromise<T> implements PromiseLike<T> { | |||
| export class SyncPromise<T> implements PromiseLike<T> { | |||
There was a problem hiding this comment.
I wonder if we can remove all sync promise usage in browser environments and only use it for node.
size-limit report
|
AbhiPrasad
force-pushed
the
abhi-sync-promise-static
branch
from
c9b54ab to
29774ca
Compare
|
Closing due to low value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.