Skip to content

feat(utils): kill unused promise buffer api #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

mitsuhiko
Copy link
Contributor

Remove some unused public API.

Copy link
Member

@JonasBa JonasBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch on remove. I didnt want to actually expose the underlying array, just to make sure nobody can use it, but I guess since it should only be used by us, it's ok.

@mitsuhiko
Copy link
Contributor Author

Yeah I wanted to not expose this at all, but due to how the tests are structured that was the only way to get rid of the length api.

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (7f1fe2d) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 20.35 KB 20.35 KB -0.02% 🔽
@sentry/browser - CDN Bundle (minified) 64.99 KB 64.96 KB -0.06% 🔽
@sentry/browser - Webpack 22.35 KB 22.33 KB -0.08% 🔽
@sentry/browser - Webpack - gzip = false 76.5 KB 76.47 KB -0.06% 🔽
@sentry/react - Webpack 22.38 KB 22.37 KB -0.07% 🔽
@sentry/nextjs Client - Webpack 46.49 KB 46.48 KB -0.02% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.51 KB 28.5 KB -0.04% 🔽

@mitsuhiko mitsuhiko merged commit b43b496 into master Dec 20, 2021
@mitsuhiko mitsuhiko deleted the feature/kill-promise-buffer-length branch December 20, 2021 11:44
@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants