Skip to content

test(browser): Add integration tests for captureException #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

onurtemizkan
Copy link
Collaborator

Part of: #4333

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2021

size-limit report

Path Base Size (4cd71c5) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.72 KB 19.72 KB +0.01% 🔺
@sentry/browser - CDN Bundle (minified) 62.76 KB 62.77 KB +0.01% 🔺
@sentry/browser - Webpack 22.25 KB 22.25 KB 0%
@sentry/browser - Webpack - gzip = false 75.92 KB 75.92 KB 0%
@sentry/react - Webpack 22.29 KB 22.29 KB 0%
@sentry/nextjs Client - Webpack 46.41 KB 46.41 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.37 KB 28.37 KB +0.01% 🔺

@onurtemizkan onurtemizkan changed the title Add integration tests for captureException test(browser): Add integration tests for captureException Dec 21, 2021
@smeubank smeubank added this to the Release Stability milestone Dec 21, 2021
Sentry.init({
dsn: 'https://[email protected]/1337',
beforeSend: (event, hint) => {
event.hint = hint;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to assert on the hint, we can just do that in unit tests

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 22, 2021 21:25
@AbhiPrasad AbhiPrasad merged commit accf5af into master Dec 22, 2021
@AbhiPrasad AbhiPrasad deleted the onur/public-api-tests-capture-exception branch December 22, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants