Skip to content

test(tracing): Fix flaky integration tests of multiple requests. #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

test(tracing): Fix flaky integration tests of multiple requests. #4384

merged 1 commit into from
Jan 11, 2022

Conversation

onurtemizkan
Copy link
Collaborator

Wrapped page.goto and multiple page.waitForRequest calls inside an outer Promise.all to avoid potential race conditions.

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (e0eba88) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.77 KB 19.77 KB +0.02% 🔺
@sentry/browser - CDN Bundle (minified) 62.94 KB 62.94 KB +0.01% 🔺
@sentry/browser - Webpack 22.31 KB 22.31 KB 0%
@sentry/browser - Webpack - gzip = false 76.19 KB 76.19 KB 0%
@sentry/react - Webpack 22.34 KB 22.34 KB 0%
@sentry/nextjs Client - Webpack 46.48 KB 46.48 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.43 KB 28.43 KB +0.02% 🔺

@AbhiPrasad AbhiPrasad merged commit 33aef95 into master Jan 11, 2022
@AbhiPrasad AbhiPrasad deleted the onur/fix-flaky-request-tests branch January 11, 2022 14:45
@AbhiPrasad AbhiPrasad added this to the Release Stability milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release Stability
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @AbhiPrasad