Skip to content

fix(tracing): Export SpanStatus enum #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

This enum is deprecated, but we should still export it. It should be
treeshaken out, so there should be no bundle impact.

This enum is deprecated, but we should still export it. It should be
treeshaken out, so there should be no bundle impact.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

size-limit report

Path Base Size (86fa701) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.68 KB 19.68 KB +0.01% 🔺
@sentry/browser - CDN Bundle (minified) 62.89 KB 62.9 KB +0.01% 🔺
@sentry/browser - Webpack 22.21 KB 22.21 KB 0%
@sentry/browser - Webpack - gzip = false 76.02 KB 76.02 KB 0%
@sentry/react - Webpack 22.24 KB 22.24 KB 0%
@sentry/nextjs Client - Webpack 46.23 KB 46.24 KB +0.02% 🔺
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.22 KB 28.23 KB +0.02% 🔺

@AbhiPrasad AbhiPrasad force-pushed the abhi-export-spanstatus branch from 5ca950a to f2c3416 Compare February 1, 2022 16:29
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 1, 2022 17:59
@AbhiPrasad AbhiPrasad merged commit f89a842 into master Feb 1, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-export-spanstatus branch February 1, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants