Skip to content

build(ci): Add es6 bundle to size-limit #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Feb 8, 2022

This will help better justify decisions between es5 and es6 going forward

Atm there is a 10% decrease when going from es5 -> es6.

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll admit I'm confused. Shouldn't @sentry/browser - Webpack (gzipped) and @sentry/browser - Webpack (minified) be looking at different files? And shouldn't the two ES6 ones also be looking at different files?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

size-limit report

Path Base Size (448244b) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.69 KB 0 B removed
@sentry/browser - CDN Bundle (minified) 62.91 KB 0 B removed
@sentry/browser - Webpack 22.21 KB 0 B removed
@sentry/browser - Webpack - gzip = false 76.02 KB 0 B removed
@sentry/react - Webpack 22.24 KB 0 B removed
@sentry/nextjs Client - Webpack 46.31 KB 0 B removed
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.22 KB 0 B removed
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 0 B 19.69 KB added
@sentry/browser - ES5 CDN Bundle (minified) 0 B 62.91 KB added
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 0 B 18.51 KB added
@sentry/browser - ES6 CDN Bundle (minified) 0 B 56.8 KB added
@sentry/browser - Webpack (gzipped + minified) 0 B 22.21 KB added
@sentry/browser - Webpack (minified) 0 B 76.02 KB added
@sentry/react - Webpack (gzipped + minified) 0 B 22.24 KB added
@sentry/nextjs Client - Webpack (gzipped + minified) 0 B 46.31 KB added
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 0 B 28.23 KB added

@AbhiPrasad
Copy link
Member Author

One is gzipped + minified and the other is just minified. You can see the value of the gzip option passed in to see. Both gzip and non-gzip will still point to the same file. I can update them to better represent that.

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it. Thanks, that's definitely clearer!

Two other suggestions, up to you if you want to do them:

  1. Label the ES5 CDN bundle the same way we label the ES6 one.
  2. Move the ES6 CDN bundle to be up with the ES5 ones, for easier comparison.

Regardless, this is a good addition!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 9, 2022 01:25
@AbhiPrasad AbhiPrasad merged commit c8b3691 into master Feb 9, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-es6-size-limit branch February 9, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants