Skip to content

Add missing peer dependencies to Gatsby package #4550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing peer dependencies to Gatsby package #4550

wants to merge 1 commit into from

Conversation

aaronadamsCA
Copy link
Contributor

Fixes #4549 by copying missing peer dependencies from packages/nextjs/package.json.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes #4549 by copying missing peer dependencies from `packages/nextjs/package.json`.
@AbhiPrasad
Copy link
Member

Hey thanks for making a PR! We are current discussing peer deps in webpack plugin, so we are holding off on merging this. cc @kamilogorek

@AbhiPrasad AbhiPrasad added Package: gatsby Issues related to the Sentry Gatsby SDK Status: Needs Discussion labels Feb 11, 2022
@aaronadamsCA
Copy link
Contributor Author

No problem, and it's easily fixable locally with Yarn 3 packageExtensions, which is what I'm doing today.

@AbhiPrasad
Copy link
Member

We'll be addressing the webpack dep here: getsentry/sentry-webpack-plugin#350, so closing this PR. Thanks for the help!

@AbhiPrasad AbhiPrasad closed this Feb 14, 2022
@aaronadamsCA
Copy link
Contributor Author

Thanks @AbhiPrasad. What about the React dependency?

@aaronadamsCA aaronadamsCA deleted the patch-1 branch February 15, 2022 11:02
@AbhiPrasad
Copy link
Member

Ah that’s my bad, we can re-open to take care of react!

@aaronadamsCA
Copy link
Contributor Author

aaronadamsCA commented Feb 15, 2022

No problem - i'll file a new one-line PR now!

Edit: #4576

@aaronadamsCA
Copy link
Contributor Author

@AbhiPrasad, it looks like the making-Webpack-optional got reverted (IMO correctly).

Again, my repo is fine thanks to packageExtensions, but you may want to merge this additional change after all.

@AbhiPrasad
Copy link
Member

Yup, we should get to that, we'll update when we upgrade the webpack plugin dep across the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: gatsby Issues related to the Sentry Gatsby SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing peer dependencies in Gatsby package
2 participants