-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(tracing): track Cursor.toArray
method for Mongo
#4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): track Cursor.toArray
method for Mongo
#4563
Conversation
I have a question: What happend if i I'm trying to achieve something like this while tracing cursor:
To achieve this i'm creating a new span and passing it to I assuming if will not close it explicitly it should calculate time based on child spans. Am i right? |
Cursor.toArray
method for Mongo
If the span is not explicitly closed, it will not be sent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good as a initial start, we can come back and iterate as appropriate afterwards!
@AbhiPrasad do you have any ideas how to achieve what've described? What would be if the parent span would be closed earlier than child spans? Again i want to explicitly show in tracing than cursor is created with some params and then these methods are called on the cursor. I want this tracks to be coupled to each other. Of course i can implement it differently and for each cursor method invocation just create a separate span and merge data spanContenxt from cursor creation and actual async method call. |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@AbhiPrasad any news about that? |
Superceded by #6337 |
Closes: #4495
Also added tests for mapReduce patching.