feat(eslint): Allow short circuit expressions

[lobsterkatie]

This changes the default eslint config in order to allow expressions of the form someBoolean && doStuff() or someBoolean && (someVariable = someValue) (which are just alternate, slightly shorter forms of single-line if blocks), in order to be able to use them when checking whether or not to emit logs.

[github-actions]

size-limit report

Path	Base Size (21a623b)	Current Size	Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified)	20.42 KB	20.42 KB	+0.01% 🔺
@sentry/browser - ES5 CDN Bundle (minified)	65.23 KB	65.23 KB	0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified)	19 KB	19 KB	-0.01% 🔽
@sentry/browser - ES6 CDN Bundle (minified)	58.25 KB	58.25 KB	0%
@sentry/browser - Webpack (gzipped + minified)	22.25 KB	22.25 KB	0%
@sentry/browser - Webpack (minified)	76.26 KB	76.26 KB	0%
@sentry/react - Webpack (gzipped + minified)	22.28 KB	22.28 KB	0%
@sentry/nextjs Client - Webpack (gzipped + minified)	46.4 KB	46.4 KB	0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)	27.25 KB	27.25 KB	-0.01% 🔽
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)	25.61 KB	25.61 KB	-0.01% 🔽

[AbhiPrasad]

Can we please name this feat(eslint) as it’ll affect the downstream consumers of our eslint config package.

[AbhiPrasad]

We’ll have to take care in code review to make sure we don’t all any non-debug usages of this to proliferate, which is slightly annoying tbh.

I’m fine with the slightly more verbose code from the if statements 🤷‍♂️ (Also makes git blame a lot cleaner)

Will leave it up to you though, I trust your judgment here (I often have unfounded worries lol)

[lobsterkatie]

We’ll have to take care in code review to make sure we don’t all any non-debug usages of this to proliferate, which is slightly annoying tbh.

I’m fine with the slightly more verbose code from the if statements 🤷‍♂️ (Also makes git blame a lot cleaner)

Will leave it up to you though, I trust your judgment here (I often have unfounded worries lol)

If I can make the thing I was attempting a few days ago work (automatically injecting isDebugBuild() so we don't have to remember to write it next to every logger call, and so that users of our npm packages can use it to treeshake their own apps), then we actually won't need this, because only our built code will include the checks. Writing it this way, with the short circuit, is actually geared towards that, since that's a much easier form in which to inject the check. In the meantime, though, in the interests of moving things along, I'm doing it manually, which requires this change.