Skip to content

fix(ember): Fix Test Flake #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2022
Merged

fix(ember): Fix Test Flake #4725

merged 4 commits into from
Mar 18, 2022

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Mar 16, 2022

Checking if recent branch was the cause of a new broccoli error, will try checking deps next.

k-fish added 2 commits March 16, 2022 08:58
Revert "fix(ember): Fix merging env config (#4714)"

This reverts commit cc44957.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2022

size-limit report

Path Base Size (f7e2796) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.49 KB 19.49 KB 0%
@sentry/browser - ES5 CDN Bundle (minified) 62.17 KB 62.17 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.12 KB 18.11 KB -0.01% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 55.5 KB 55.5 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.41 KB 22.41 KB 0%
@sentry/browser - Webpack (minified) 76.82 KB 76.82 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.45 KB 22.45 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.62 KB 46.62 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.37 KB 25.36 KB -0.01% 🔽
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.72 KB 23.72 KB -0.01% 🔽

@lobsterkatie
Copy link
Member

lobsterkatie commented Mar 17, 2022

I tested this without the revert commit, and it seems to work (see below). Can we pull that out of this PR? No reason to revert a fix if we don't have to.

image

@k-fish
Copy link
Member Author

k-fish commented Mar 17, 2022

@lobsterkatie I'm not sure that this isn't just the flake passing, the other change (the lock / package) shouldn't have any actual effect.

@lobsterkatie
Copy link
Member

lobsterkatie commented Mar 17, 2022

@lobsterkatie I'm not sure that this isn't just the flake passing, the other change (the lock / package) shouldn't have any actual effect.

Hmmm. Since this latest round of the tests failing (the past week or so, starting before the env config merging PR), I haven't been able to get them to pass, no matter how many times I run it, until the version change you did. I guess, let's see if this latest CI run passes.

UPDATE: Seems good! I'm going to merge it so we can get master green again, and we can come back to the config merging if things start acting up again.

@lobsterkatie lobsterkatie merged commit 75768e3 into master Mar 18, 2022
@lobsterkatie lobsterkatie deleted the fix/ember-test-flake branch March 18, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants