fix(build): Run integration bundle builds sequentially #4740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run in CI, the parallelized integration bundle builds are being flaky, and sometimes seeming to timeout before they complete. (They don't output a timeout message, but the ones that succeed take an extraordinarily long time, and others just log as
killed. Because of the parallelization, of course, it's impossible to tell which builds are killed, but the end result is that not all bundles get build and included in the artifact upload.) I can only speculate that this is because the GHA machine is trying to do too many things at once and runs out of memory.This therefore removes the parallelization, by not backgrounding each build job as it starts, but instead running each one in turn, which should result in all bundles getting built.
Note: This significantly increases build time in CI. In a future PR, the integration bundle builds can get split over a number of different GHA jobs, which will restore the parallelization, without asking any one job to handle more than it's capable of.