Skip to content

ref(utils): Use type predicates for isError and isString #4757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2022
Merged

ref(utils): Use type predicates for isError and isString #4757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/utils/src/is.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const objectToString = Object.prototype.toString;
* @param wat A value to be checked.
* @returns A boolean representing the result.
*/
export function isError(wat: unknown): boolean {
export function isError(wat: unknown): wat is Error {
switch (objectToString.call(wat)) {
case '[object Error]':
case '[object Exception]':
Expand Down Expand Up @@ -68,7 +68,7 @@ export function isDOMException(wat: unknown): boolean {
* @param wat A value to be checked.
* @returns A boolean representing the result.
*/
export function isString(wat: unknown): boolean {
export function isString(wat: unknown): wat is string {
return isBuiltin(wat, 'String');
}

Expand Down