Skip to content

fix(core): Export new transport methods #4778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix(core): Export new transport methods #4778

merged 1 commit into from
Mar 24, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 24, 2022 •
edited
Loading

  • Export types and methods for new transports in core package
  • Add logic for cleaning up event and adding SDK details to
    createEventEnvelope. This is duplicating code, but considering we
    are going to refactor this in v7, we can take the temporary bundle
    size hit.

This is extracted from #4765

@AbhiPrasad
fix(core): Export new transport methods
2f34dbd 
- Export types and methods for new transports in core package
- Add logic for cleaning up event and adding SDK details to
  `createEventEnvelope`. This is duplicating code, but considering we
  are going to refactor this in v7, we can take the temporary bundle
  size hit.
@AbhiPrasad AbhiPrasad requested review from lforst and Lms24 March 24, 2022 14:35
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 24, 2022
Merged
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.61 KB (+0.14% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.76 KB (+0.48% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.21 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.25 KB (+0.53% 🔺)
@sentry/browser - Webpack (gzipped + minified) 22.74 KB (+0.07% 🔺)
@sentry/browser - Webpack (minified) 80.67 KB (+0.37% 🔺)
@sentry/react - Webpack (gzipped + minified) 22.77 KB (+0.06% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.71 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.49 KB (+0.14% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.83 KB (+0.1% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 24, 2022 16:27
Lms24
Lms24 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the time being

@AbhiPrasad AbhiPrasad merged commit 2b7a00f into master Mar 24, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-new-transport-fix branch March 24, 2022 16:59
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pre 7.0.0 Work
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @Lms24