Skip to content

fix(tests): Silence dummy output in tests #4979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Apr 26, 2022

We have a number of tests which log messages to the console, for reasons other than communicating with the person running the tests. When trying to debug a large number of tests, across the whole repo, it's distracting to see this output (some of which actually even looks like failing tests). This silences that output, so it doesn't seem like tests are erroring when they're not.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.35 KB (-8.87% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 57.52 KB (-10.98% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.13 KB (-9.18% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 51.75 KB (-10.73% 🔽)
@sentry/browser - Webpack (gzipped + minified) 20.94 KB (-9.88% 🔽)
@sentry/browser - Webpack (minified) 72.5 KB (-11.28% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.98 KB (-9.89% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.97 KB (-4.34% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.13 KB (-7.45% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.64 KB (-7.52% 🔽)

@lobsterkatie lobsterkatie force-pushed the kmclb-silence-dummy-output-in-tests branch from 04efc9d to fd1ccbe Compare April 26, 2022 08:51
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 26, 2022
@lobsterkatie lobsterkatie force-pushed the kmclb-silence-dummy-output-in-tests branch from fd1ccbe to 5270b64 Compare April 26, 2022 13:57
@lobsterkatie lobsterkatie force-pushed the kmclb-silence-dummy-output-in-tests branch from 5270b64 to 3626b1f Compare April 26, 2022 16:10
@lobsterkatie lobsterkatie force-pushed the 7.x branch 2 times, most recently from 0040b0f to 299aeb3 Compare April 26, 2022 22:40
@lobsterkatie lobsterkatie force-pushed the kmclb-silence-dummy-output-in-tests branch 2 times, most recently from 4decf68 to a4113c9 Compare April 27, 2022 07:32
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the changes (from "here" link). They're looking good to me.

@Lms24 Lms24 self-assigned this Apr 27, 2022
@lobsterkatie lobsterkatie force-pushed the kmclb-silence-dummy-output-in-tests branch from a4113c9 to f2dee4e Compare April 27, 2022 13:55
@lobsterkatie lobsterkatie marked this pull request as ready for review April 27, 2022 14:59
@lobsterkatie lobsterkatie merged commit 87cf8c5 into 7.x Apr 27, 2022
@lobsterkatie lobsterkatie deleted the kmclb-silence-dummy-output-in-tests branch April 27, 2022 15:00
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
We have a number of tests which log messages to the console, for reasons other than communicating with the person running the tests. When trying to debug a large number of tests, across the whole repo, it's distracting to see this output (some of which actually even looks like failing tests). This silences that output, so it doesn't seem like tests are erroring when they're not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants