-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(tests): Silence dummy output in tests #4979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
04efc9d
to
fd1ccbe
Compare
fd1ccbe
to
5270b64
Compare
5270b64
to
3626b1f
Compare
0040b0f
to
299aeb3
Compare
4decf68
to
a4113c9
Compare
Lms24
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the changes (from "here" link). They're looking good to me.
a4113c9
to
f2dee4e
Compare
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
We have a number of tests which log messages to the console, for reasons other than communicating with the person running the tests. When trying to debug a large number of tests, across the whole repo, it's distracting to see this output (some of which actually even looks like failing tests). This silences that output, so it doesn't seem like tests are erroring when they're not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of tests which log messages to the console, for reasons other than communicating with the person running the tests. When trying to debug a large number of tests, across the whole repo, it's distracting to see this output (some of which actually even looks like failing tests). This silences that output, so it doesn't seem like tests are erroring when they're not.