-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(nextjs): Update webpack-plugin and change how cli binary is detected #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We just cut a release unfortunately, and I don't think we'll have another one before v7. @smeubank should be reasonable for us to just add this to v7 right? Another incentive for folks to upgrade! |
once we are confident with the fix let's communicate it to vercel, and work with them that it is tested as soon as we have a beta version ready to test with at least an example NextJs application. Then we can ask the folks from the issue to help us with testing it as well |
Confirmed on my local repo that it works correctly. Still need to verify on Vercel, but we need beta (or normal) release for this. |
Pre
Post
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mashing approve while holding my nose...
(To be clear, that's about the need for the workaround in the first place. I appreciate you fixing this!)
@kamilogorek I'm gonna take this over and rebase onto |
It ain't nice, but it works. More details in the code comment.