Skip to content

docs(core): Improve documentation of Options and ClientOptions properties #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 29, 2022

This very small PR just slightly improves documentation of (mostly) user-facing Options / ClientOptions properties. Also cleaned up a TODO which we agreed we won't do for now.

This came up while reviewing ClientOptions and Options.
ref: https://getsentry.atlassian.net/browse/WEB-837

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.29 KB (-9.18% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 57.25 KB (-11.4% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.07 KB (-9.48% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 51.49 KB (-11.19% 🔽)
@sentry/browser - Webpack (gzipped + minified) 18.74 KB (-19.37% 🔽)
@sentry/browser - Webpack (minified) 60.65 KB (-25.78% 🔽)
@sentry/react - Webpack (gzipped + minified) 18.76 KB (-19.4% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.43 KB (-11.7% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.08 KB (-7.68% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.64 KB (-7.52% 🔽)

@Lms24 Lms24 merged commit 031ffa7 into 7.x Apr 29, 2022
@Lms24 Lms24 deleted the lms-doc-options branch April 29, 2022 15:51
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
…operties (#5019)

slightly improve documentation of (mostly) user-facing Options / ClientOptions properties. Remove a TODO which we agreed we won't do for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants