Update Ember plugin docs #507
Conversation
|
👍 Thanks for the PR! Will review this soon. |
|
Thanks, @benvinegar! |
|
|
||
| .. code-block:: javascript | ||
|
|
||
| Raven.config('___PUBLIC_DSN___').install() | ||
| app.import('node_modules/raven-js/dist/raven.js'); | ||
| app.import('bower_components/raven-js/dist/plugins/ember.js'); |
There was a problem hiding this comment.
Ember CLI actually uses Bower. Fixed in 1bece62.
There was a problem hiding this comment.
I squashed this fix btw and rebased the PR onto latest master.
|
Was there any reason you omitted the CommonJS instructions (from the Angular docs)? Do they not apply? |
This is based on the Angular docs, but suited for Ember / Ember CLI.
joeyespo
force-pushed
the
update-ember-plugin-docs
branch
from
a53a86a to
1bece62
Compare
|
@benvinegar Yeah, it seems like noise at this point. Raven should be loaded before your application code so an initialization bug doesn't slip by, so this documents how to do just that. |
You can still use Raven.js + CommonJS using a bundler (e.g. webpack/browserify), and still initialize it before your application runs. This is how we run Raven.js on getsentry.com. |
Good point. I'm sure there's a better way than what I have here. |
This is based on the Angular docs, but suited for Ember / Ember CLI.