Skip to content

fix(build): Fix references to rollup.bundle.config.js #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2022
Merged

fix(build): Fix references to rollup.bundle.config.js #5074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d907cda
point to correct rollup config when watching CDN bundle builds
lobsterkatie May 11, 2022
b05e0a2
fix debugging instructions
lobsterkatie May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"build:rollup": "rollup -c rollup.npm.config.js",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch build:types:watch",
"build:bundle:watch": "rollup --config --watch",
"build:bundle:watch": "rollup --config rollup.bundle.config.js --watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:dev:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
Expand Down
4 changes: 2 additions & 2 deletions packages/browser/test/integration/debugging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ These tests are hard to debug, because the testing system is somewhat complex, s
- `suites.yourTestFile.js`:
- Use `it.only` to only run the single test you're interested in.

- Repo-level `rollup.config.js`:
- Repo-level `rollup/bundleHelpers.js`:
- Comment out all bundle variants except whichever one `run.js` is turning into `artifacts/sdk.js`.

- Browser-package-level `rollup.config.js`:
- Browser-package-level `rollup.bundle.config.js`:
- Build only one of `es5` and `es6`.

- Run `build:bundle:watch` in a separate terminal tab, so that when you add `console.log`s to the SDK, they get picked up.
Expand Down
2 changes: 1 addition & 1 deletion packages/tracing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"build:rollup": "rollup -c rollup.npm.config.js",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch build:types:watch",
"build:bundle:watch": "rollup --config --watch",
"build:bundle:watch": "rollup --config rollup.bundle.config.js --watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
Expand Down
2 changes: 1 addition & 1 deletion packages/wasm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"build:rollup": "rollup -c rollup.npm.config.js",
"build:types": "tsc -p tsconfig.types.json",
"build:watch": "run-p build:cjs:watch build:esm:watch build:bundle:watch build:types:watch",
"build:bundle:watch": "rollup --config --watch",
"build:bundle:watch": "rollup --config rollup.bundle.config.js --watch",
"build:cjs:watch": "tsc -p tsconfig.cjs.json --watch",
"build:dev:watch": "run-p build:cjs:watch build:esm:watch build:types:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
Expand Down