feat(dev): Add default Node version for CI jobs #5081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
approved these changes
May 12, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
In our CI workflow, we currently use version 1 of GHA's `setup-node` action, whose default Node version is 10. Though we could (and should) update to version 3 of the action, whose default is Node 16, the `setup-node` docs[1] recommend explicitly setting a version for greater control and clarity. This does so, by adding the default Node version as an env variable and using it in all jobs which don't otherwise specify their version. [1] https://github.com/actions/setup-node#usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI workflow, we currently use version 1 of GHA's
setup-nodeaction, whose default Node version is 10. Though we could (and should) update to version 3 of the action, whose default is Node 16, thesetup-nodedocs recommend explicitly setting a version for greater control and clarity. This does so, by adding the default Node version as an env variable and using it in all jobs which don't otherwise specify their version.