Skip to content

ref(utils): Remove Object.setPrototypeOf polyfill #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022

Conversation

lobsterkatie
Copy link
Member

Now that we're ES6-only, we no longer need to polyfill Object.setPrototypeOf. (The last browser to gain support for it did so in September of 2015.)

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.75 KB (-6.91% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.19 KB (-9.95% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.49 KB (-7.25% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.43 KB (-9.56% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.27 KB (-17.06% 🔽)
@sentry/browser - Webpack (minified) 61.3 KB (-24.98% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.3 KB (-17.1% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.76 KB (-11.02% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.41 KB (-6.4% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.96 KB (-6.24% 🔽)

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny bit scary but probably fine 👍

@lobsterkatie
Copy link
Member Author

Tiny bit scary but probably fine 👍

If it helps, we already use the real version elsewhere in the SDK, and it's never been an issue.

@lobsterkatie lobsterkatie merged commit f4a1840 into 7.x May 12, 2022
@lobsterkatie lobsterkatie deleted the kmclb-remove-object-setPrototypeOf-polyfill branch May 12, 2022 08:24
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
Now that we're ES6-only, we no longer need to polyfill `Object.setPrototypeOf`. (The last browser to gain support for it did so in September of 2015[1].)

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/setPrototypeOf#browser_compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants