ref(serverless): Use GitHub action to zip lambda layer (second try) #5093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
kamilogorek
suggested changes
May 12, 2022
Lms24
approved these changes
May 13, 2022
There was a problem hiding this comment.
Thanks for improving the Lambda layer build experience! I think it's good to unify the build process of the Node layer as much as possible with the Python layer. And anything that makes build-aws-lambda-layer.js script shorter and less complex is a good change IMO :D
Just left a small comment with a possible improvement for the future
EDIT: Found one more thing, see below
Lms24
reviewed
May 13, 2022
Co-authored-by: Lukas Stracke <[email protected]>
antonpirker
deleted the
antonpirker/WEBBACKEND-146-build-aws-lambda-layer-w-github-action
branch
kamilogorek
reviewed
May 13, 2022
Comment on lines
+536
to
+537
| echo "SDK_VERSION=$SDK_VERSION" | ||
| echo "SDK_VERSION=$SDK_VERSION" >> $GITHUB_ENV |
There was a problem hiding this comment.
Suggested change
| echo "SDK_VERSION=$SDK_VERSION" | |
| echo "SDK_VERSION=$SDK_VERSION" >> $GITHUB_ENV | |
| echo "SDK_VERSION=$SDK_VERSION" | tee -a $GITHUB_ENV |
There was a problem hiding this comment.
tee -a does exactly what you did in 2 lines :)
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
…5093) * Removed zipping from build script * Assemble Lambda Layer zip using GitHub action. Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does basically two things:
build-awslambda-layer.jsto NOT zip the layer and put all layer contents in/dist-serverless/dist-serverlesscraftrelease script takes it and puts it into AWS Lambda.)