Skip to content

Remove some duplicate code #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Remove some duplicate code #511

merged 1 commit into from
Feb 17, 2016

Conversation

tremby
Copy link
Contributor

@tremby tremby commented Feb 17, 2016

This line of code was here twice, along with its comment; likely a copy and paste error at some point.

@mattrobenolt
Copy link
Contributor

Ah, thanks. 🍰 🍦

mattrobenolt added a commit that referenced this pull request Feb 17, 2016
@mattrobenolt mattrobenolt merged commit 4ff1b84 into getsentry:master Feb 17, 2016
@tremby tremby deleted the remove-duplicate-code branch February 17, 2016 00:21
@benvinegar
Copy link
Contributor

Whoa whoa whoa @mattrobenolt! Talk about haste! There are plenty of good reasons why this code is duplicated!!!!

@benvinegar
Copy link
Contributor

jk 👍

@tremby
Copy link
Contributor Author

tremby commented Feb 17, 2016

While you guys are here, what I was trying to investigate when I noticed this duplicate code is how exactly "release" is handled. Some Sentry docs suggest using a tag "version", but then Raven JS has this config option to pass "release", separate from tags, and it's rendered as if it were a tag in Sentry as far as I can tell. Is "release" special in some way? Can you point me at code or docs?

@mattrobenolt
Copy link
Contributor

Yeah, we handle release as a first class citizen in the API, but internally it gets transformed into a tag. It's more like a "special" tag, since we use it for internal purposes to manage releases and whatnot.

@mattrobenolt
Copy link
Contributor

Also, those docs are misleading. We should update that. A tag "version" is not the same thing as a release. It's likely these docs were written before releases were a native thing.

@tremby
Copy link
Contributor Author

tremby commented Feb 17, 2016

Okay, all understood. I'll switch my code to send "release" instead. Found how to send it properly in PHP Raven, too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants