Skip to content

feat(build): Add ability to combine package-specific rollup config with standard options #5144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented May 20, 2022

Currently, the functions which we use to generate rollup configs accept a small handful of pre-defined options for customizing the output. For greater flexibility, this adds the option of passing arbitrary rollup options, which will get merged into what is currently being generated.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.42 KB (-3.6% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.11 KB (-6.97% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.26 KB (-3.18% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.8 KB (-7.2% 🔽)
@sentry/browser - Webpack (gzipped + minified) 20 KB (-13.92% 🔽)
@sentry/browser - Webpack (minified) 63.34 KB (-22.49% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.03 KB (-13.96% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.5 KB (-9.48% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.1 KB (-3.75% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.63 KB (-3.49% 🔽)

@lobsterkatie lobsterkatie force-pushed the kmclb-add-package-specific-config-rollup-option branch from ef491b2 to 450161c Compare May 20, 2022 07:25
@lobsterkatie lobsterkatie marked this pull request as ready for review May 20, 2022 07:26
@lobsterkatie lobsterkatie merged commit 161d302 into 7.x May 20, 2022
@lobsterkatie lobsterkatie deleted the kmclb-add-package-specific-config-rollup-option branch May 20, 2022 07:48
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
…th standard options (#5144)

Currently, the functions which we use to generate rollup configs accept a small handful of pre-defined options for customizing the output. For greater flexibility, this adds the option of passing arbitrary rollup options, which will get merged into what is currently being generated.
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants