ref(tracing): Simplify sample_rate serialization for DSC #5475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
reviewed
Jul 27, 2022
packages/tracing/src/transaction.ts
Outdated
| rate !== undefined | ||
| ? rate.toLocaleString('fullwide', { useGrouping: false, maximumFractionDigits: 16 }) | ||
| : undefined; | ||
| const sample_rate = rate !== undefined ? JSON.stringify(rate) : undefined; |
There was a problem hiding this comment.
Do we even need the extra JSON.stringify call? Won't just doing sample_rate: rate below be enough?
There was a problem hiding this comment.
Good point. We can simplify it further to that but I think we still have to convert it toString (if I understand this test correctly).
Lms24
changed the title
AbhiPrasad
approved these changes
Jul 28, 2022
Lms24
force-pushed
the
lms-dsc-sampleRate-json
branch
from
2775a4d to
dd66615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our formatting logic of the
sample_ratevalue when the dynamic sampling context (DSC) is populated. Instead of usingNumber.toLocaleStringwith a bunch of options (which theoretically is supported by all browsers; but it turns out that IE11 doesn't support thefullwidelocale we use), we now simply convert the numbertoStringto do the job. Given that Relay now supports parsing the sample_rate from JSON format, we can drop our previous formatting logic.Deleted a test that's IMO no longer necessary, covering the conversion of exponential to decimal notation.
Fixes #5466