fix(integrations): Don't add empty stack trace in RewriteFrames
#5625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
commented
Aug 22, 2022
| .replace(/^[A-Z]:/, '') // remove Windows-style prefix | ||
| .replace(/\\/g, '/') // replace all `\\` instances with `/` | ||
| .replace(/^[A-Z]:/, '') // remove Windows-style prefix | ||
| .replace(/\\/g, '/') // replace all `\\` instances with `/` |
There was a problem hiding this comment.
git is doing those spacing changes automatically, should I leave it as is or return to the original spacing?
EDIT: It seems like vscode enforces the removal of additional spaces where prettier wants the additional spaces.
AbhiPrasad
requested changes
Aug 29, 2022
AbhiPrasad
changed the title
RewriteFrames
Co-authored-by: Abhijeet Prasad <[email protected]>
AbhiPrasad
reviewed
Aug 30, 2022
|
Hey guys, I'm still seeing this error here. I'm struggling to get my Expo Hermes source maps working properly. This is the issue example.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids adding an empty stack trace when a stack trace is not defined.
By doing that, you'll no longer see the following error message at Sentry:
Fixes #5609 and potentially fixes getsentry/sentry-react-native#2429
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).