fix(nextjs): Start navigation transactions on same-route navigations #5642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5641
Currently we are not starting transactions in Next.js when navigating from one page to another, but within the same route (eg. from
/users/42
to/users/1337
, both are on the same route/users/[id]
).This PR fixes this by starting a transaction for those navigations by looking at the window pathname instead. (See code changes for reason why we're not starting transactions when just the query string changes)