fix(node): Use normalizeDepth when creating an event from unknown input
#5689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-fix-normalizeToSize-depth
branch
from
7bba630 to
8ebddd4
Compare
|
@AbhiPrasad @lobsterkatie IMO this change is sound and we can go through with this. Any objections? |
|
Nope. Seems good to me! I do think we should do it for browser also. |
lforst
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the
normalizeDepthinit option when creating events from an unknown input. It potentially fixes #5687 where a user reported that callingSentry.captureExceptionwith a deep custom object, thenormalizeDepthisn't respected but the depth defaults to 3.Note: I'm not sure if this behaviour was intentional or if we have a bug. Opened this quick PR with an idea how to fix it. Since I'm gone for the next weeks, reviewer(s) please feel free to change, close or merge this PR! Was just a quick idea.
If we decide to go with this, we might want to apply the same fix to the Browser SDKs event builder.