Skip to content

ref(nextjs): Update vercel testing script #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lobsterkatie
Copy link
Member

This is a small refactor to our set-up-branch-for-test-app-use.sh vercel script, which prepares the current branch to be tested on vercel by deleting packages unrelated to the nextjs SDK, thereby speeding up the vercel build.

The only consequential change is a switch from specifying which packages should get deleted to specifying which packages shouldn't. (The list of deletion targets kept falling out of date, each time we added a new package. With this change, it should in theory be evergreen.)

"nextjs" | "core" | "hub" | "browser" | "node" | "react" | "tracing" | "utils" | "integrations")
continue
;;
# Dev dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah. Why does the auto-formatter insist on indenting these comments? 😖

@AbhiPrasad
Copy link
Member

While we are here, can we just convert this to a node script?

@lobsterkatie
Copy link
Member Author

While we are here, can we just convert this to a node script?

If I get to it in the next few days, sure, but otherwise I think I'll merge this just to get it in, and then we can look at converting all of the vercel scripts separately.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, sounds good to me

@lobsterkatie
Copy link
Member Author

While we are here, can we just convert this to a node script?

If I get to it in the next few days, sure, but otherwise I think I'll merge this just to get it in, and then we can look at converting all of the vercel scripts separately.

Cool, sounds good to me

Haven't gotten a chance to do this, so I'm going to merge this in and come back to the conversion question in a different PR.

@lobsterkatie lobsterkatie merged commit 036e2a0 into master Sep 23, 2022
@lobsterkatie lobsterkatie deleted the kmclb-nextjs-use-package-whitelist-in-vercel-script branch September 23, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants