Skip to content

ref(browser): Use configured transport as fallback for client reports #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Sep 22, 2022

Fixes #4736

Update the client report sending logic to fallback on whatever transport is initialized on the client. This fallback is also used when a user configures custom transport options.

@AbhiPrasad AbhiPrasad requested a review from lforst September 22, 2022 12:32
@AbhiPrasad AbhiPrasad force-pushed the abhi-client-reports-fallback branch from 4398bb9 to 71c917d Compare September 22, 2022 12:37
@AbhiPrasad AbhiPrasad force-pushed the abhi-client-reports-fallback branch from 71c917d to 87b14ac Compare September 22, 2022 12:39
@AbhiPrasad AbhiPrasad marked this pull request as ready for review September 22, 2022 12:39
@lforst lforst changed the title ref(browser): use any transport as fallback for client reports ref(browser): Use any transport as fallback for client reports Sep 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.43 KB (-0.21% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.08 KB (-0.14% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.06 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.01 KB (-0.13% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.82 KB (-0.2% 🔽)
@sentry/browser - Webpack (minified) 64.37 KB (-0.18% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.84 KB (-0.2% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.74 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.88 KB (-0.13% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.31 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad merged commit acc9cb1 into master Sep 22, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-client-reports-fallback branch September 22, 2022 13:28
@AbhiPrasad AbhiPrasad changed the title ref(browser): Use any transport as fallback for client reports ref(browser): Use configured transport as fallback for client reports Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client reports should not be sent via the Beacon API when transportOptions includes headers
2 participants