Skip to content

fix(tracing): Remove circular dep warning in build with GLOBAL #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix(tracing): Remove circular dep warning in build with GLOBAL #6030

merged 1 commit into from
Oct 24, 2022

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Oct 24, 2022 •
edited
Loading

Extract WINDOW declaration from index.ts to remove circular dependency warning when building with rollup.

@AbhiPrasad AbhiPrasad requested a review from timfish October 24, 2022 15:01
timfish
timfish approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@timfish timfish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error about something similar in browser but no such error in tracing!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) October 24, 2022 15:06
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.48 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.31 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.11 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.64 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.85 KB (0%)
@sentry/browser - Webpack (minified) 65.05 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.88 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.8 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.26 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.64 KB (-0.02% 🔽)

@AbhiPrasad AbhiPrasad merged commit 51c1191 into master Oct 24, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-circ-dep branch October 24, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @timfish