Skip to content

fix(react): Relax React Router 6 RouteObject typing. #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

onurtemizkan
Copy link
Collaborator

Fixes: #6264

  • Added errorElement type to both NonIndexRouteObject and IndexRouteObject
  • Also extended RouteObject with Record<string, any> to prevent such things breaking users' builds in the future.

@onurtemizkan onurtemizkan requested a review from lforst November 23, 2022 13:33
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.16 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.63 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.9 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.93 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.37 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.78 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad merged commit e97ae86 into master Nov 23, 2022
@AbhiPrasad AbhiPrasad deleted the onur/relax-routeobject-types branch November 23, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 7.21.0 CreateRouterFunction's RouteObject doesn't support errorElement type .
2 participants