Skip to content

build(ember): Remove unused build:extras for ember package #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 23, 2022

This removes build:extra from the ember package. It is not really needed at this stage, as far as I can tell.

For reference: What ember build in the context of an addon (=package) does is not really related to the library, but it builds the test app. Ember addons don't need to be built in any way, they are always built by the host app.

@mydea mydea added Package: ember Issues related to the Sentry Ember SDK Dev: Build labels Nov 23, 2022
@mydea mydea requested review from lobsterkatie and a team November 23, 2022 15:38
@mydea mydea self-assigned this Nov 23, 2022
@mydea mydea requested review from lforst and removed request for a team November 23, 2022 15:38
@mydea mydea merged commit de6b477 into master Nov 23, 2022
@mydea mydea deleted the fn/remove-ember-build-extra branch November 23, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: Build Package: ember Issues related to the Sentry Ember SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants