Skip to content

Add documentation about inlinining sources inside source maps #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2016

Conversation

benvinegar
Copy link
Contributor

Our documentation is not clear that both source maps and source files need to be accessible by Sentry, and users are sometimes confused when dealing with source map issues inside the app.

This does two things:

  • adds --source-map-include-source to the UglifyJS2 example
  • adds an admonition about why inline sources are preferred

Note that Webpack produces inline sources by default (can't seem to figure out if this is even configurable).

cc @mattrobenolt

@mattrobenolt
Copy link
Contributor

🍪

@benvinegar benvinegar merged commit c2f59cb into master Jun 25, 2016
@benvinegar benvinegar deleted the inline-sources-docs branch June 25, 2016 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants