Skip to content

types(node): add profilesSampleRate #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2022
Merged

types(node): add profilesSampleRate #6318

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b52996
types(options): add profileSampleRate
JonasBa Nov 28, 2022
1d22767
types(options): add profileSampleRate
JonasBa Nov 28, 2022
9d7fa63
fix: add jsdoc comment
JonasBa Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/node/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,9 @@ export interface NodeOptions extends Options<NodeTransportOptions>, BaseNodeOpti
* Configuration options for the Sentry Node SDK Client class
* @see NodeClient for more information.
*/
export interface NodeClientOptions extends ClientOptions<NodeTransportOptions>, BaseNodeOptions {}
export interface NodeClientOptions extends ClientOptions<NodeTransportOptions>, BaseNodeOptions {
/**
* Sets profiling sample rate when @sentry/profiling-node is installed
*/
profilesSampleRate?: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a JSDoc here, explaining what this option does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I added it

}