-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta: Update changelog for 7.22.0 #6325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
@@ -4,6 +4,15 @@ | |||
|
|||
- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott | |||
|
|||
## 7.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h: this should just be a patch, the core feat
is completely internal to us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're extending the API in two places. Adding an argument to recordDroppedEvent
is definitely a change that forces a minor and the remix typing changes are also technically a minor.
A minor is just correct here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recordDroppedEvent
is not completely internal to us. Users can pass that hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are both fair points, but the general likelyhood of an external user using recordDroppedEvent
is extremely low. I wouldn't try to follow semvar to that precisely, I would optimize for making sure that upgrades are easy as possible, and so patches >> minor. This also applies to the remix typing changes, it's just a bug fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing offline, let's make it a minor.
No description provided.