Skip to content

Revert "build(replay): Remove replay version string replacement (#6367)" #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 1, 2022

This PR reverts #6367 as the Replay team would like to continue injecting the version separately from the SDK to detect version package version mismatches more easily.

Note: This will not avoid the 7.x bump in the next Replay release, it will just enable a scenario like users use the SDK on e.g. 7.25 and Replay on 7.24 and replay events will have the 7.24 version in their metadata.

Note 2: This makes a very good case for exporting Replay via the SDK to, as it avoids version mismatches all together. Same for Tracing later on...

@Lms24 Lms24 added Dev: Build Package: replay Issues related to the Sentry Replay SDK labels Dec 1, 2022
@Lms24 Lms24 requested review from billyvg and mydea December 1, 2022 17:26
@Lms24 Lms24 self-assigned this Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.57 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.36 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.12 KB (0%)
@sentry/browser - Webpack (minified) 65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.97 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.41 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.85 KB (+0.02% 🔺)
@sentry/replay index.js 37.08 KB (-0.34% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.05 KB (-0.34% 🔽)
@sentry/replay - Webpack (minified) 124.65 KB (-0.28% 🔽)

@Lms24 Lms24 merged commit da36b2a into master Dec 2, 2022
@Lms24 Lms24 deleted the lms-replay-revert-version-ii branch December 2, 2022 08:27
@Lms24 Lms24 mentioned this pull request Dec 2, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: Build Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants