Skip to content

ref(nextjs): Use loader for rather than webpack plugin for injecting release #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Dec 5, 2022

This replicates the release-injection functionality provided by the webpack plugin using the prefix loader instead, in hopes of fixing #5734, wherein the release value is somehow getting stuck on an old value. (My theory is that the file injected by the webpack plugin to inject the release is getting cached. This therefore switches to injecting the code setting the release using a loader, so that it's in the same file as, and just before, the Sentry.init() call.)

Fixes #5734

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.6 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.37 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.26 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.13 KB (0%)
@sentry/browser - Webpack (minified) 65.83 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.16 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 46.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.87 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.74 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.23 KB (0%)

@lobsterkatie lobsterkatie requested a review from lforst December 5, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry sending the wrong release when capturing an exception
2 participants