fix(node): Move profilesSampleRate into BaseNodeOptions
#6409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
changed the title
profilesSampleRate into Node Client OptionsprofilesSampleRate into BaseNodeOptions
Lms24
approved these changes
Dec 5, 2022
| @@ -0,0 +1,51 @@ | |||
| import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node'; | |||
There was a problem hiding this comment.
Is this test supposed to be part of this PR?
There was a problem hiding this comment.
Nope, just forked off the wrong branch 🤦
size-limit report 📦
|
This was referenced Dec 5, 2022
|
Ahh, thanks @AbhiPrasad, I wrongly assumed that was the correct type to extend 🙏🏼 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #6318 (comment)
By only declaring
profilesSampleRateinNodeClientOptions, it meant that the type was not available inSentry.init. This fixes that.