Skip to content

ref(replay): Rename replaysSampleRate to replaysSessionSampleRate #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Dec 5, 2022

We wanted this config option to be a bit more specific in that it should be the sample rate for "session" replays (vs. on error samples). The previous name could be mistaken as a sample rate that affects both types of replays.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.6 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.37 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.26 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.13 KB (0%)
@sentry/browser - Webpack (minified) 65.83 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.16 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.01 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.87 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.74 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.23 KB (+0.01% 🔺)

@billyvg billyvg requested review from mydea and Lms24 December 5, 2022 21:37
@billyvg billyvg marked this pull request as ready for review December 5, 2022 21:37
We wanted this config option to be a bit more specific in that it should be the sample rate for "session" replays (vs. on error samples). The previous name could be mistaken as a sample rate that affects both types of replays.
@mydea mydea force-pushed the ref-replay-rename-replaysSampleRate-to-replaysSessionSampleRate branch from 42d5710 to fc64d80 Compare December 6, 2022 09:55
@mydea mydea merged commit 8ac9ec4 into master Dec 6, 2022
@mydea mydea deleted the ref-replay-rename-replaysSampleRate-to-replaysSessionSampleRate branch December 6, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants