Skip to content

fix(tracing): Check for otel before loading db module #6461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

AbhiPrasad
Copy link
Member

To make sure we don't override possible OpenTelemetry instrumentation, check for the instrumenter to be configured as otel before we dynamically load the database modules to instrument.

@AbhiPrasad AbhiPrasad requested a review from mydea December 7, 2022 14:34
To make sure we don't override possible OpenTelemetry instrumentation,
check for the instrumenter to be configured as `otel` before we
dynamically load the database modules to instrument.
@AbhiPrasad AbhiPrasad force-pushed the abhi-require-based-on-otel branch from 5587e12 to bfdf1ec Compare December 7, 2022 14:35
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.67 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.94 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.49 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.26 KB (0%)
@sentry/browser - Webpack (minified) 66.24 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.29 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.14 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.53 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.96 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.79 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.91 KB (0%)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 7, 2022 14:51
@AbhiPrasad AbhiPrasad self-assigned this Dec 7, 2022
@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Dec 7, 2022
@AbhiPrasad AbhiPrasad merged commit d9d8429 into master Dec 7, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-require-based-on-otel branch December 7, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants