ci: Split node & browser unit tests #6535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/unit-node-browser-tests
branch
2 times, most recently
from
0c8046b to
9ee6705
Compare
size-limit report 📦
|
mydea
requested review from
a team,
Lms24 and
lobsterkatie
and removed request for
a team
mydea
requested review from
AbhiPrasad and
lforst
and removed request for
lobsterkatie
lforst
reviewed
Dec 15, 2022
package.json
Outdated
Comment on lines
29
to
30
| "test-ci-browser": "TESTS_SKIP=node ts-node ./scripts/test.ts", | ||
| "test-ci-node": "TESTS_SKIP=browser ts-node ./scripts/test.ts", |
There was a problem hiding this comment.
Can't remember: Does this work on windows?
There was a problem hiding this comment.
good point, I guess we can use cross-env!
Lms24
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Generally, I think it's good to split up this huge unit test job. I'm just wondering if there's a downside to not testing browser packages with different node versions... Maybe we'd miss some bugs appearing in SSR scenarios? But I guess overall that's an edge case and we're testing NextJS and Remix anyway in the node jobs. So I'd say let's do it 👍
mydea
force-pushed
the
fn/unit-node-browser-tests
branch
from
bbe3f1e to
076b133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two main things: