Skip to content

test(react): Make react unit tests silent #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2023
Merged

test(react): Make react unit tests silent #6545

merged 1 commit into from
Jan 3, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 15, 2022

Currently, we have a bunch of console.warn() outputs there which mess up the test logs a bit.

@mydea
test(react): Make react unit tests silent
3666958 
Currently, we have a bunch of `console.warn()` outputs there which mess up the test logs a bit.
@mydea mydea added Package: react Issues related to the Sentry React SDK Type: Tests labels Dec 15, 2022
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad December 15, 2022 08:30
@mydea mydea self-assigned this Dec 15, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.78 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.27 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.57 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.8 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (0%)
@sentry/browser - Webpack (minified) 66.48 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.57 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.19 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.87 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.1 KB (0%)

@mydea mydea merged commit 86d3e06 into master Jan 3, 2023
@mydea mydea deleted the fn/make-react-tests-silent branch January 3, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
Package: react Issues related to the Sentry React SDK Type: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24