Skip to content

fix(nextjs): Proxy public key with tunnelRoute option #6562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Dec 15, 2022

Fixes #6539

Replay events need a sentry_key query parameter. The current implementation of tunnelRoute doesn't proxy that query parameter leading to a 401 response from Sentry.

This PR fixes this issue by also proxying the sentry_key parameter. It is now a bit easier for adblockers to fingerprint for these proxy requests with the additional query parameter but we have to deal with that.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.78 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.27 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.56 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.8 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (0%)
@sentry/browser - Webpack (minified) 66.48 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.61 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.19 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.89 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.12 KB (+0.02% 🔺)

@lforst
Copy link
Contributor Author

lforst commented Dec 16, 2022

Fixed via #6568 instead

@lforst lforst closed this Dec 16, 2022
@lforst lforst deleted the lforst-send-sentry-key branch January 16, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Replay] NextJS tunnel fails to passthrough Replay payloads
1 participant