ref(replay): Extract sendReplay functionality into functions
#6751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Jan 12, 2023
| @@ -414,14 +411,12 @@ describe('Integration | sendReplayEvent', () => { | |||
|
|
|||
| await advanceTimers(30000); | |||
| expect(mockSendReplayRequest).toHaveBeenCalledTimes(4); | |||
| expect(spySendReplay).toHaveBeenCalledTimes(4); | |||
There was a problem hiding this comment.
Note: We cannot spy on recursive calls of modules, it seems, so this is never incremented. IMHO this is well enough tested by ensure that sendReplayRequest is called X times, we don't really care that much about sendReplay does.
size-limit report 📦
|
mydea
force-pushed
the
fn/send-replay-extract
branch
from
bee9cf7 to
f84854d
Compare
mydea
force-pushed
the
fn/send-replay-extract
branch
from
f84854d to
caec2f7
Compare
Lms24
approved these changes
Jan 12, 2023
| @@ -34,7 +34,7 @@ type SentReplayExpected = { | |||
| replayEventPayload?: ReplayEventPayload; | |||
| recordingHeader?: RecordingHeader; | |||
| recordingPayloadHeader?: RecordingPayloadHeader; | |||
| events?: ReplayRecordingData; | |||
| recordingData?: ReplayRecordingData; | |||
There was a problem hiding this comment.
great change, "event" is overloaded enough already 😅
| @@ -110,7 +110,7 @@ describe('Integration | stop', () => { | |||
| jest.runAllTimers(); | |||
| await new Promise(process.nextTick); | |||
| expect(replay).toHaveLastSentReplay({ | |||
| events: JSON.stringify([ | |||
| recordingData: JSON.stringify([ | |||
There was a problem hiding this comment.
Just to double check: This renaming doesn't change anything for the actual envelope content that is sent to Sentry, right? Just don't wanna risk some problem with Relay not finding the field it expects in the envelope
There was a problem hiding this comment.
no, this basically reads the SendReplayData passed around!
Lms24
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts this out into a more functional style.
In addition, it also changes the
timestampwe put on the replay to always reflect the time we've added it, no matter if it was retried.This also renames a few things for clarity (e.g.
eventsthat was often passed around is actuallyrecordingData, so we may as well reflect that in order to be clear about recordingData vs. events).Note: This depends on #6733, where I'll need to merge the changes once that is merged.