Skip to content

test(nextjs): Disable doubleEndMethodOnVercel on Node 10 #6792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

AbhiPrasad
Copy link
Member

Fixes #6784

Since doubleEndMethodOnVercel seems only to be flaky on Node 10, and it's very rare that NextJS apps are running on Node 10 (and impossible on Vercel), prevent this test from running in Node 10.

@AbhiPrasad AbhiPrasad requested a review from lforst January 16, 2023 14:20
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.61 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.37 KB (0%)
@sentry/browser - Webpack (minified) 66.54 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.69 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.83 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.28 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.43 KB (-0.83% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.65 KB (-0.96% 🔽)

@AbhiPrasad AbhiPrasad merged commit 0122a9f into master Jan 16, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-double-end-skip-node-10 branch January 16, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky doubleEndMethodOnVercel test
2 participants