fix(otel): Always set baggage regardless of active transaction #6819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Jan 17, 2023
AbhiPrasad
commented
Jan 17, 2023
| @@ -23,7 +23,7 @@ export const SENTRY_SPAN_PROCESSOR_MAP: Map<SentrySpan['spanId'], SentrySpan> = | |||
| export class SentrySpanProcessor implements OtelSpanProcessor { | |||
| public constructor() { | |||
| addGlobalEventProcessor(event => { | |||
| const otelSpan = trace.getActiveSpan() as OtelSpan; | |||
| const otelSpan = trace && trace.getActiveSpan && (trace.getActiveSpan() as OtelSpan | undefined); | |||
There was a problem hiding this comment.
Snuck this change in as it seems that getActiveSpan is not defined for some versions - will investigate more but at least this unhandled errors in production.
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6807
Set baggage even when there is no active transaction. We do this because we are responsible for propagating baggage via the
W3CBaggagePropagatorwhich theSentryPropagatorinherits from.