feat(replay): Handle worker loading errors #6827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
reviewed
Jan 17, 2023
mydea
force-pushed
the
fn/replay-buffer-worker
branch
from
7bd60a8 to
637f194
Compare
mydea
force-pushed
the
fn/replay-buffer-worker
branch
from
a6858e6 to
7895218
Compare
mydea
force-pushed
the
fn/replay-buffer-worker
branch
from
59b1a12 to
7663718
Compare
Lms24
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
I think this is a good change, considering the direction we want to move towards with the worker. For the long term, we might be able to replace the worker and proxy classes with a functional approach which might help bundle size. But I think this something that rather belongs to #6459. So let's tackle that some time in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the replay buffer to handle errors in the worker.
While with the current worker implementation this is just a rather safe approach, it becomes necessary when we want to load a worker from an external (e.g. CDN) url. In that case, if loading the worker fails, we need to handle this in an async way.
With this PR, when compression is enabled, we don't use the
EventBufferCompressionWorkerbut a wrappingEventBufferProxy.This proxy initializes both an
EventBufferArrayas well as anEventBufferCompressionWorkerunder the hood. Initially, any events & flushes are handled by the simple buffer. Once we know the compression worker has successfully loaded, we switch any pending events over and start using the worker buffer. This way, no event should ever be lost, and even in-flight flushes should all work as expected.